Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access log for read op also outputs file handle #5143

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Access log for read op also outputs file handle #5143

merged 1 commit into from
Sep 5, 2024

Conversation

polyrabbit
Copy link
Contributor

Two reasons:

  1. To align with the write op.
  2. Admin can know read concurrency of the same file.

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.68%. Comparing base (b6582db) to head (032ab45).
Report is 26 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #5143       +/-   ##
===========================================
+ Coverage   44.65%   63.68%   +19.03%     
===========================================
  Files         159       24      -135     
  Lines       43347    16006    -27341     
===========================================
- Hits        19355    10194     -9161     
+ Misses      21566     4431    -17135     
+ Partials     2426     1381     -1045

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies merged commit e4eee28 into juicedata:main Sep 5, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polyrabbit @davies